Skip to content

[stable23] fix(CI): Run repair steps against Oracle DB #36889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 6 commits into from
Mar 7, 2023
Merged

[stable23] fix(CI): Run repair steps against Oracle DB #36889

nickvergessen merged 6 commits into from
Mar 7, 2023

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 28, 2023

Backport of #36781

  • 6fb0da7 Was not backported as the class does not exist in stable24

@nickvergessen
fix(CI): Run repair steps against Oracle DB
f616a06 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
First run unit tests so they don't fail
fc27faa 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fail the repair command when an error happened
438e860 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(OCC): Don't throw in the repair step for phone validation
188b6c6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix appconfig compatibility with Oracle DB
3f5ac26 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Feb 28, 2023
@nickvergessen nickvergessen requested review from a team, come-nc and juliusknorr February 28, 2023 08:21
@nickvergessen nickvergessen self-assigned this Feb 28, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl and icewind1991 and removed request for a team February 28, 2023 08:21
@nickvergessen
fix(CI): Fix OCI phpunit job name
ed1ae0f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 9631394 into stable23 Mar 7, 2023
@nickvergessen nickvergessen deleted the backport/36781/stable23 branch March 7, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

+1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @vitormattos @come-nc