fix(weather_status): Override the default NcActions aria-label

[susnux]

• Resolves: [BITV] 9.2.5.3/2.1 - The visible label "Set location for weather" does not appear in the accessible name of the button in the same form as it is overridden by the use of aria-label="Actions". In this case voice activation would fail as visible text is not in accessible name. (1) #37018

Summary

Currently the default aria-label of NcActions hides the menu text, this is fixed by replacing the aria-label with the menu text.

Note: I first thought about removing the aria label and let the browser fallback to the text, but the property requires a string so :aria-label="null" works but a future change might replace all falsy values with the default Actions text.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

/compile

[artonge]

Nice !
Can you add some before/after screenshots?
I could not reproduce the overlapping of the aria-label with the text.

[susnux]

Nice ! Can you add some before/after screenshots? I could not reproduce the overlapping of the aria-label with the text.

There is no visual overlapping, but the aria-label is overriding the inner text so the visual label does not appear in the names:

before	after

[susnux]

/backport to stable26

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport