Enable caldav push notifications by default #40103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
enhancement
3. to review
hamza221
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
Member
|
Reverting everything, not just changing the default value of the setting? |
Contributor
Author
Member
|
I don't understand how it answers #39158, sorry. :( |
Contributor
Author
GretaD
approved these changes
Aug 31, 2023
Contributor
GretaD
left a comment
GretaD
left a comment
There was a problem hiding this comment.
i only checked the vue and js changes
miaulalala
approved these changes
Aug 31, 2023
hamza221
force-pushed
the
enh/enable-caldav-push-notifications-by-default
branch
from
d84a49c to
5193cd5
Compare
ChristophWurst
requested changes
Sep 6, 2023
| ?string $calendarDisplayName, | ||
| array $principalEmailAddresses, | ||
| array $users = []):void { | ||
| if ($this->config->getAppValue('dav', 'sendEventRemindersPush', 'no') !== 'yes') { |
Member
There was a problem hiding this comment.
like @tcitworld said we should flip the default value but leave the option to turn the feature off
hamza221
force-pushed
the
enh/enable-caldav-push-notifications-by-default
branch
from
5193cd5 to
c9e5dbd
Compare
tcitworld
approved these changes
Sep 8, 2023
ChristophWurst
approved these changes
Sep 11, 2023
Member
|
Failure of |
ChristophWurst
added
4. to release
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
enh/enable-caldav-push-notifications-by-default
branch
from
4d778a7 to
823908b
Compare
hamza221
deleted the
enh/enable-caldav-push-notifications-by-default
branch
ChristophWurst
added
the
pending documentation
Member
|
Needs admin docs for how to set sendEventRemindersPush and an entry in the admin upgrade section for 28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist