Skip to content

Conversation

@LukasReschke
Copy link
Member

Removes 8 requests. Follow-up to #3988

Signed-off-by: Lukas Reschke lukas@statuscode.ch

Removes 8 requests.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Mar 24, 2017
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Mar 24, 2017
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @nickvergessen and @rullzer to be potential reviewers.

@LukasReschke LukasReschke mentioned this pull request Mar 24, 2017
3 tasks
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2017
@codecov-io
Copy link

Codecov Report

Merging #4042 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4042      +/-   ##
============================================
+ Coverage     54.23%   54.23%   +<.01%     
  Complexity    21272    21272              
============================================
  Files          1310     1310              
  Lines         81182    81174       -8     
  Branches       1284     1284              
============================================
  Hits          44027    44027              
+ Misses        37155    37147       -8
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 70.8% <0%> (+0.38%) 514 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b6b18...4d68324. Read the comment docs.

@LukasReschke LukasReschke merged commit c628095 into master Mar 24, 2017
@LukasReschke LukasReschke deleted the merge-js-forsharing-code branch March 24, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants