-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Email option in occ user:add command
#40726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e7b4a3 to
2b2901f
Compare
2b2901f to
e45d734
Compare
fd4822d to
b9e4d89
Compare
b9e4d89 to
f295fde
Compare
occ use:add commandocc user:add command
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but with the comments the code would be simpler/easier to read in the future
f295fde to
ef6691c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not good for when newUser.sendEmail is off, this will generate a random password but not send it.
Using --email should not change how password is handled, unless newUser.sendEmail is on and password-from-env was not given.
This needs to work and set email:
occ user:add --password-from-env --email bob@example.com bob
This needs to work and set email, if newUser.sendEmail is off it should ask for password same as without --email:
occ user:add --email bob@example.com bob
ef6691c to
7c218ca
Compare
Signed-off-by: Philip Gatzka <philip.gatzka@mailbox.org>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Herman van Rink <rink@initfour.nl>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
7c218ca to
ce24923
Compare
|
Possible performance regression detected Show Output |
|
is performance regression something to worry about? Seems unrelated to this PR. |
It is unrelated. |
|
Great! Thanks a lot for that! 💙 |
occ. #25319Summary
Builds upon #29368
This adds an occ command option (
email) during the addition of a user to auto-generate a password and send a link to the email address to set a new password if:password-from-envoption was not passedemailis given and validDocs
Checklist