-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
move apps management from left apps menu to right settings menu #4079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @nickvergessen and @skjnldsv to be potential reviewers. |
|
nice. this was fast 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4079 +/- ##
============================================
+ Coverage 54.23% 54.24% +0.01%
Complexity 21285 21285
============================================
Files 1310 1310
Lines 81187 81175 -12
Branches 1284 1284
============================================
+ Hits 44032 44036 +4
+ Misses 37155 37139 -16
Continue to review full report at Codecov.
|
LukasReschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely 🚀
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me integrate that into #4077 instead
|
:D #4077? @karlitschek do you go around asking multiple people to do the same thing? ;) |
|
Now part of #4077 |
The problem was that apps management was just way too present there. Apps aren’t added and managed that often so it shouldn’t be that directly visible.
Also when you only have few apps, the plus icon is very easy to confuse with the upload button, and it’s a lot bigger too.
Before & after:

As discussed @karlitschek Please review @nextcloud/designers
Oh and btw @nickvergessen @schiessle I guess someone of you can help me with placing it correctly – I actually want the »Apps« entry between »Admin« and »Users« in the menu. Currently it’s just between Help and Log out which is strange.