Match slashes in ../{id} resource routes

[rullzer]

Fixes #2954

Before we could match on /{id} however if the id contains a /
this would not match properly. But since we define the resource routes
internally we now make sure that we match all chars (up until the ?).

to test:

1. create a group foo/bar
2. Delete the group

Before: nope
Now: yes, master

CC: @hirschrobert

[mention-bot]

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BernhardPosselt, @Xenopathic and @icewind1991 to be potential reviewers.

[nickvergessen]

I think we should specify that on the routes which are affected:
https://github.com/nextcloud/notifications/blob/master/appinfo/routes.php#L24

Not in general. And with your current approach I think you even kill existing restrictions?

[nickvergessen]

This will also cause problems with:
/groups/{groupId} vs. /groups/{groupId}/subadmins ?! (provisioning api) also the name does not match there, so they still wouldnt allow slashes...

[rullzer]

we don't do it in general. Only for resources like https://github.com/nextcloud/server/blob/master/settings/routes.php#L40

I see no use case where you'd generate a resource url like <prefix>/foo/bar and only want to match on foo and ignore bar (because bar will be ignored as the resources specifies itself as <prefix>/{id})

[rullzer]

@nickvergessen so this way now or are you going to rewrite it to use the provisioning api?

[nickvergessen]

yeah let's try it

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

Reverted in #4381