Skip to content

Conversation

@icewind1991
Copy link
Member

Support doing $cache[] = 'foo'

Only the CappedMemoryCache is ever used that way, since doing this doesn't make sense on "real" memecaches

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 29, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Mar 29, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer.

@MorrisJobke
Copy link
Member

What is the background of this?

@icewind1991
Copy link
Member Author

The query logger (used mainly by xray) was switched to the capped cache to prevent memory issues on long running processes, but since that uses the push semantics it currently doesn't properly hold the logged queries

@MorrisJobke
Copy link
Member

But there is no way to get the information out of the cache?

@MorrisJobke
Copy link
Member

Ah found it - the offsetGet

@rullzer rullzer force-pushed the capped-memcache-push branch from 2414ea0 to 955419e Compare March 29, 2017 20:47
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 29, 2017
@MorrisJobke
Copy link
Member

A unit tests fails:

There was 1 failure:
1) Test\AppTest::testEnabledApps with data set #3 (null, array('files', 'app1', 'app3', 'appforgroup1', 'appforgroup12', 'appforgroup2', 'dav', 'federatedfilesharing', 'lookup_server_connector', 'provisioning_api', 'twofactor_backupcodes', 'workflowengine'), false)
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'files'
     1 => 'app1'
     2 => 'app3'
-    3 => 'appforgroup1'
-    4 => 'appforgroup12'
-    5 => 'appforgroup2'
-    6 => 'dav'
-    7 => 'federatedfilesharing'
-    8 => 'lookup_server_connector'
-    9 => 'provisioning_api'
-    10 => 'twofactor_backupcodes'
-    11 => 'workflowengine'
+    3 => 'dav'
+    4 => 'federatedfilesharing'
+    5 => 'lookup_server_connector'
+    6 => 'provisioning_api'
+    7 => 'twofactor_backupcodes'
+    8 => 'workflowengine'
 )
/drone/src/github.com/nextcloud/server/tests/lib/AppTest.php:487

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 29, 2017
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants