-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
support pushing to CappedMemoryCache #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer. |
|
What is the background of this? |
|
The query logger (used mainly by xray) was switched to the capped cache to prevent memory issues on long running processes, but since that uses the push semantics it currently doesn't properly hold the logged queries |
|
But there is no way to get the information out of the cache? |
|
Ah found it - the |
2414ea0 to
955419e
Compare
|
A unit tests fails: |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
955419e to
0aeb595
Compare
Support doing
$cache[] = 'foo'Only the
CappedMemoryCacheis ever used that way, since doing this doesn't make sense on "real" memecaches