fix(dav): Avoid date diffing if PHP is buggy #41722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
AndyScherzinger,
SystemKeeper and
hamza221
ChristophWurst
requested review from
miaulalala and
tcitworld
as code owners
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
SystemKeeper
approved these changes
Nov 24, 2023
Contributor
SystemKeeper
left a comment
SystemKeeper
left a comment
There was a problem hiding this comment.
Verified with https://3v4l.org/Xc968, looks good to me 👍
hamza221
approved these changes
Nov 24, 2023
This was referenced Nov 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PHP<8.1.10 had a bug where the diff of two datetime objects results in garbage. Doing our own date diffing is hard, so we are just hiding the relative date in this specific case.
This is only an issue for Nextcloud because the PHP version shipped with current ubuntu LTS is affected by this.
Screenshots
Before is faked because I don't have the bug locally thanks to a maintained PHP version on Arch.
Checklist