fix(dav): don't schedule out-of-office jobs for dates in the past #41778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
feature: caldav
Member
Author
|
/backport to stable28 |
miaulalala
approved these changes
Nov 27, 2023
st3iny
force-pushed
the
fix/dav/schedule-ooo-jobs
branch
from
6149b1c to
a3f2302
Compare
st3iny
commented
Nov 28, 2023
Comment on lines
-53
to
-54
| private IConfig $appConfig, | ||
| private IManager $calendarManager, |
Member
Author
There was a problem hiding this comment.
Kind of unrelated but my PHPStorm complained that those 2 parameters are not used anywhere outside the constructor (only written).
ChristophWurst
approved these changes
Nov 28, 2023
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/dav/schedule-ooo-jobs
branch
from
a3f2302 to
26248d0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There should be no job scheduled and no start event emitted if the start date of an out-of-office period lies in the past. The same goes for end events.
I also added some tests to prevent regressions in the future.
Checklist