Skip to content

Migrate openResult method to SearchResult component #41785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Nov 29, 2023
Merged

Migrate openResult method to SearchResult component #41785

AndyScherzinger merged 1 commit into from
Nov 29, 2023

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 28, 2023 •
edited by ChristophWurst
Loading

Ref #41381 (comment)

After moving the SearchResult to its own component and leaving out the openResult method, the search results do not lead anywhere but but error out.

@nfebe nfebe force-pushed the fix-open-search-result branch from 86cf466 to 3f4a7a2 Compare November 28, 2023 09:12
@nfebe nfebe mentioned this pull request Nov 28, 2023
Closed
22 tasks
ChristophWurst
ChristophWurst previously requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#41381 (comment)

this element should be a real link

@nfebe
Copy link
Contributor Author

nfebe commented Nov 28, 2023 •
edited
Loading

#41381 (comment)

this element should be a real link

@ChristophWurst using the href attribute of NcListItem would force the search result to open in a new tab, is this the desired behavior?

https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcListItem/NcListItem.vue#L319

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 28, 2023

Then the component needs a new prop to influence this behavior

@nfebe
Copy link
Contributor Author

nfebe commented Nov 28, 2023

@ChristophWurst that makes sense, I have created these issue for that here : nextcloud-libraries/nextcloud-vue#4880 and here #41800

Because this breaks search entirely, so this PR should restore the old initial before of using JavaScript to trigger the routing.

@ChristophWurst ChristophWurst dismissed their stale review November 28, 2023 14:21

Needs more work

@nfebe nfebe force-pushed the fix-open-search-result branch from 3f4a7a2 to 0710327 Compare November 28, 2023 14:29
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Nov 29, 2023
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 29, 2023

/backport to stable28

@nfebe nfebe force-pushed the fix-open-search-result branch from 0710327 to 5220d89 Compare November 29, 2023 15:02
@nfebe
Copy link
Contributor Author

nfebe commented Nov 29, 2023

/compile amend /

ChristophWurst
ChristophWurst approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for simple clicks again

The approach of window.location is still there and problematic

@nfebe nfebe force-pushed the fix-open-search-result branch 2 times, most recently from ab654cb to f639997 Compare November 29, 2023 15:47
@nfebe
Copy link
Contributor Author

nfebe commented Nov 29, 2023

/compile amend /

@nfebe @nextcloud-command
Migrate openResult method to SearchResult component
00bb1bc 
After moving the `SearchResult` to its own component and leaving
 out the openResult method, the search results do not lead anywhere but
 but error out.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 0a8ceb4 into master Nov 29, 2023
@AndyScherzinger AndyScherzinger deleted the fix-open-search-result branch November 29, 2023 18:45
@nfebe nfebe mentioned this pull request Nov 30, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@susnux susnux Awaiting requested review from susnux

Assignees

No one assigned

Labels

3. to review Waiting for reviews 28-feedback feature: search

Projects

📁 Files team
Archived in project

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

6 participants

@nfebe @ChristophWurst @AndyScherzinger @artonge @skjnldsv