accessibility fix - changed the dir attribute to have valid value #41808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
force-pushed
the
accessibility/breadcrumbs
branch
from
76d643e to
45e402a
Compare
Contributor
Author
|
/compile amend/ |
susnux
reviewed
Nov 28, 2023
emoral435
force-pushed
the
accessibility/breadcrumbs
branch
from
45e402a to
52ddcd6
Compare
emoral435
force-pushed
the
accessibility/breadcrumbs
branch
from
52ddcd6 to
bfae7c4
Compare
Contributor
Author
|
/compile amend/ |
emoral435
force-pushed
the
accessibility/breadcrumbs
branch
from
bfae7c4 to
58e3623
Compare
susnux
approved these changes
Nov 29, 2023
susnux
added
bug
3. to review
Contributor
|
/backport to stable28 |
Pytal
approved these changes
Nov 29, 2023
emoral435
added
4. to release
Contributor
Author
|
/compile amend / |
emoral435
force-pushed
the
accessibility/breadcrumbs
branch
from
2a97c3c to
d43be9b
Compare
nextcloud-command
force-pushed
the
accessibility/breadcrumbs
branch
from
d43be9b to
020a856
Compare
…eping previous value as data-dir Signed-off-by: Eduardo Morales <emoral435@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
accessibility/breadcrumbs
branch
from
020a856 to
bcc41df
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the dir attribute works with ltr, rtl, and auto values, the current values (being the path to the files) was an accessibility issue.
Changed the dir attribute to be auto, as with different language support, this will enable future languages having the right directionality of their language. Kept the path stored as a data- attribute for future support.
TODO
Images
Checklist