Add reference to issue template app #4189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @Finkregh and @MariusBluem to be potential reviewers. |
MariusBluem
requested changes
Apr 2, 2017
Member
MariusBluem
left a comment
MariusBluem
left a comment
There was a problem hiding this comment.
See my comment ... Rest seems to be fine 👍
issue_template.md
Outdated
| Insert your config.php content here | ||
| (Without the database password, passwordsalt and secret) | ||
| Insert your config.php content here. | ||
| Make sure to remove all sensitive contents such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …) |
Codecov Report
@@ Coverage Diff @@
## master #4189 +/- ##
=========================================
Coverage 53.96% 53.96%
Complexity 21266 21266
=========================================
Files 1259 1259
Lines 74136 74136
=========================================
Hits 40009 40009
Misses 34127 34127Continue to review full report at Codecov.
|
jospoortvliet
approved these changes
Apr 3, 2017
Member
|
TODO: port to the other repo's. Will work on that later today. |
jospoortvliet
pushed a commit
to nextcloud/calendar
that referenced
this pull request
Apr 4, 2017
Privacy is a thing and so is users forgetting about it ;-) ref nextcloud/server#4189
jospoortvliet
pushed a commit
to nextcloud/notifications
that referenced
this pull request
Apr 4, 2017
Privacy is a thing and so is users forgetting about it ;-) ref nextcloud/server#4189
Member
Member
|
All reviewed and merged. I pronounce this action DONE ;-) |
DeepDiver1975
pushed a commit
to owncloud/calendar
that referenced
this pull request
Aug 22, 2017
Privacy is a thing and so is users forgetting about it ;-) ref nextcloud/server#4189
DeepDiver1975
pushed a commit
to owncloud/calendar
that referenced
this pull request
Aug 25, 2017
Privacy is a thing and so is users forgetting about it ;-) ref nextcloud/server#4189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jospoortvliet Thoughts? We talked about that in the S-Bahn in Stuttgart on Friday :-)
If okay I'll merge this also on other repositories. But make sure the text is fine first :)