fix: Ensure app menu entries and dashboard welcome message have enough contrast #42401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those elements are shown directly on the background which has the `color-primary`, so they need to use `color-primary-text` instead of `color-primary-element-text` for guranteed contrast. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/app-menu-colors
branch
from
c9c46f9 to
de57e51
Compare
Contributor
Author
|
/backport fde6914 to stable28 |
Contributor
Author
|
/backport fde6914 to stable27 |
ShGKme
approved these changes
Dec 20, 2023
JuliaKirschenheuter
approved these changes
Dec 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Those elements are shown directly on the background color of
color-primaryso the text color needs to becolor-primary-textand notcolor-primary-element-text.Screenshots
Checklist