-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore(theming): fix warning of incorrect NcCheckboxRadioSwitch usage
#42834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(theming): fix warning of incorrect NcCheckboxRadioSwitch usage
#42834
Conversation
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 this was there for too long 👍
emoral435
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this change, especially because of how many lines this will declutter within the console!
Unrelated, but we should definitely fix our style guides problem for displaying this components props. Something I will assign myself for now, but do when we are done with all the accessibility issues :) here
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
510c5be to
9310dba
Compare
|
|
/backport to stable28 |
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/skjnldsv-backport 9310dba stable28 |
|
/skjnldsv-backport 9310dba to stable28 |
Summary
No visual changes.
Removes error:
Checklist