-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files): fixed aria-desciption logic for last breadcrumb #42950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
skjnldsv
merged 1 commit into
master
from
fix/a11y/41895/breadcrumb-fix-for-home-component
Jan 20, 2024
Merged
fix(files): fixed aria-desciption logic for last breadcrumb #42950
skjnldsv
merged 1 commit into
master
from
fix/a11y/41895/breadcrumb-fix-for-home-component
Jan 20, 2024
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceb5f77 to
fa29df4
Compare
ShGKme
requested changes
Jan 18, 2024
dbfbbd0 to
ea765cf
Compare
Member
Member
|
Seems @szaimen checked with German where it is not translated so no issue code-wise |
Contributor
indeed, looks like it... |
Contributor
Author
Pytal
approved these changes
Jan 19, 2024
Contributor
Author
|
/compile / |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
/backport to stable28 |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
df22929 to
81057f6
Compare
skjnldsv
approved these changes
Jan 20, 2024
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
Cleaned up the aria-description logic a bit!
Screenshots for the new changes
Checklist