Add IEMailTemplate to public OCP API #4304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds `\OCP\Mail\IMailer::createEMailTemplate` as helper so the functionality can easily be used within apps. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @rullzer and @MorrisJobke to be potential reviewers. |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
rullzer
previously requested changes
Apr 11, 2017
lib/public/Mail/IEMailTemplate.php
Outdated
| * @since 12.0.0 | ||
| */ | ||
| public function __construct(Defaults $themingDefaults, | ||
| public function __construct(\OCP\Defaults $themingDefaults, |
Member
There was a problem hiding this comment.
constructor has no place in an interface
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
dismissed
rullzer’s stale review
@rullzer Constructor adjusted. Please recheck :)
rullzer
approved these changes
Apr 11, 2017
LukasReschke
added
4. to release
This was referenced Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
\OCP\Mail\IMailer::createEMailTemplateas helper so the functionality can easily be used within apps.@MorrisJobke Strong opinions here? I'd love to have this so this can be easily used in the SharingProvider code.