enh(log): exit log() earlier if no crashreport registered #43529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
requested review from
a team,
icewind1991,
juliusknorr,
nfebe and
sorbaugh
and removed request for
a team
ArtificialOwl
force-pushed
the
enh/noid/leave-log-early-if-no-crash-reporter
branch
from
bf68594 to
18a6b62
Compare
Member
Author
|
(failing test not related) |
ArtificialOwl
force-pushed
the
enh/noid/leave-log-early-if-no-crash-reporter
branch
from
18a6b62 to
b9e0530
Compare
icewind1991
requested changes
Feb 13, 2024
Member
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
This would break BeforeMessageLoggedEvent
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
enh/noid/leave-log-early-if-no-crash-reporter
branch
from
b9e0530 to
5aff876
Compare
Member
Author
I added a |
ArtificialOwl
force-pushed
the
enh/noid/leave-log-early-if-no-crash-reporter
branch
from
5aff876 to
bf6cb92
Compare
icewind1991
reviewed
Feb 14, 2024
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
enh/noid/leave-log-early-if-no-crash-reporter
branch
from
bf6cb92 to
2232753
Compare
skjnldsv
approved these changes
Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up on the previous improvement from @juliushaertl : #35970
The idea is to avoid some formatting of the payload as soon as we know for sure that it will not be used