Skip to content

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Jun 10, 2016

Before & after
capture du 2016-06-10 18-08-22

favicon-touch favicon-touch

Fits a lot better with the rest like header and log in view. Please review @nextcloud/designers @jospoortvliet @skjnldsv
Also cc @AndyScherzinger regarding icon for the Android app. :)

@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews medium labels Jun 10, 2016
@jancborchardt jancborchardt added this to the Nextcloud 9 milestone Jun 10, 2016
@jancborchardt
Copy link
Member Author

Regarding Android as well – it will work a lot better with the header color in the app switcher so that theres only the white icon, and it’s a lot more visible on the home screen that way. :)

@MariusBluem
Copy link
Member

👍

@MariusBluem MariusBluem merged commit 74580da into master Jun 10, 2016
@MariusBluem MariusBluem deleted the color-inversion branch June 10, 2016 16:11
@skjnldsv
Copy link
Member

Don't know what am I doing here, but looks great! 👍
ps: you can gain a few kb by optimizing your svgs with svgo :)

@jancborchardt
Copy link
Member Author

@Mar1u5 please only merge stuff after it received two 👍 :)

@skjnldsv
Copy link
Member

Says the merging machine! ;)
owncloud-archive/mail#1434 (comment)

@MariusBluem
Copy link
Member

MariusBluem commented Jun 10, 2016

Shit ... mistaken with #40 (which has 2x 👍) 😒 Will never happen again 😉 @jancborchardt

@jancborchardt
Copy link
Member Author

@skjnldsv we forked ownCloud to Nextcloud. If you want to hear about the reasons check https://www.youtube.com/watch?v=iMfokaX2r8g :)
Welcome again – I also invited you to the Nextcloud design team, you should have gotten an email. :)

Also, I optimized the svgs with scour, as in the image-optimization.sh script. ;)

@skjnldsv
Copy link
Member

skjnldsv commented Jun 10, 2016

$ svgo favicon-mask.svg 
Done in 103 ms!
1.331 KiB - 32.9% = 0.894 KiB

We can do better! \o/

@jancborchardt
Copy link
Member Author

Oi, nice! Isn’t that very lossy at some point though? Cause scour already is.

@skjnldsv
Copy link
Member

skjnldsv commented Jun 10, 2016

Don't think so, I think it's optimising the redundancy of the code. Didn't looked too much to be honest :/

EDIT:

SVG files, especially exported from various editors, usually contain a lot of redundant and useless information such as editor metadata, comments, hidden elements, default or non-optimal values and other stuff that can be safely removed or converted without affecting SVG rendering result.

@jancborchardt
Copy link
Member Author

Ok, I guess we should play around with it on new icons we create. I would not compress all files right now with it because I’m pretty sure in the past I read that scour is lossy. And I also noticed some tiny tiny different position values when I opened files back up. Nothing really important but still – if it’s an even crazier compression we should check it on a case-by-case basis. Is that cool? :)

@AndyScherzinger
Copy link
Member

Integrated on android master :) nextcloud/android@f63d421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants