-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
invert colors of favicons to match header and log in site, white on blue #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Regarding Android as well – it will work a lot better with the header color in the app switcher so that theres only the white icon, and it’s a lot more visible on the home screen that way. :) |
|
👍 |
|
Don't know what am I doing here, but looks great! 👍 |
|
@Mar1u5 please only merge stuff after it received two 👍 :) |
|
Says the merging machine! ;) |
|
Shit ... mistaken with #40 (which has 2x 👍) 😒 Will never happen again 😉 @jancborchardt |
|
@skjnldsv we forked ownCloud to Nextcloud. If you want to hear about the reasons check https://www.youtube.com/watch?v=iMfokaX2r8g :) Also, I optimized the svgs with scour, as in the image-optimization.sh script. ;) |
We can do better! \o/ |
|
Oi, nice! Isn’t that very lossy at some point though? Cause scour already is. |
|
Don't think so, I think it's optimising the redundancy of the code. Didn't looked too much to be honest :/ EDIT:
|
|
Ok, I guess we should play around with it on new icons we create. I would not compress all files right now with it because I’m pretty sure in the past I read that scour is lossy. And I also noticed some tiny tiny different position values when I opened files back up. Nothing really important but still – if it’s an even crazier compression we should check it on a case-by-case basis. Is that cool? :) |
|
Integrated on android master :) nextcloud/android@f63d421 |
Before & after

Fits a lot better with the rest like header and log in view. Please review @nextcloud/designers @jospoortvliet @skjnldsv
Also cc @AndyScherzinger regarding icon for the Android app. :)