Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 3, 2024

Summary

Update from organization + remove cypress version output -> this does not test cypress...

Checklist

…on` output

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels May 3, 2024
@susnux susnux added this to the Nextcloud 30 milestone May 3, 2024
@susnux susnux requested review from Pytal, max-nextcloud and skjnldsv May 3, 2024 18:26
@skjnldsv skjnldsv merged commit b5c3c3a into master May 6, 2024
@skjnldsv skjnldsv deleted the fix/drop-unneeded-cypress-version branch May 6, 2024 06:52
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv
Copy link
Member

@susnux just realize we now npm run build on tests too?
Is that really necessary? 🤔

@susnux
Copy link
Contributor Author

susnux commented Feb 21, 2025

Is that really necessary? 🤔

Only if we test things from dist (which is - IIRC - done for the test:jsunit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants