Skip to content

Conversation

@jancborchardt
Copy link
Member

Can anyone explain to me though what it is so I can add the actual text @icewind1991 @karlitschek @LukasReschke

Also – why is this in the personal settings of every user? This sounds awfully admin-like and technical to me.

ref #4478 #4540

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@mention-bot
Copy link

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991 and @Henni to be potential reviewers.

@MariusBluem
Copy link
Member

Also – why is this in the personal settings of every user? This sounds awfully admin-like and technical to me.

I think this is only on personal page if you have enabled external storages app, where you might need to import own certificates to reach specific mounts for user-specified storages 😉 But I have to agree with you. @jancborchardt

@karlitschek
Copy link
Member

karlitschek commented Apr 27, 2017

Nice. If you as core contributor need explanation what this is then it is pretty clear that we need to provide explanation to 'normal' users too. ;-)

@LukasReschke
Copy link
Member

Also – why is this in the personal settings of every user? This sounds awfully admin-like and technical to me.

As a remark: I still consider it a bad functionality design that we allow regular users to accept any SSL certificates. Should be an admin only functionality, but well, I'm repeating myself.

But yes, @MariusBluem explanation is as usual correct 😉

@jancborchardt
Copy link
Member Author

Ok, so how can we force this to be part of the »External storages« section, just below it? Currently it’s broken up by the twofactor stuff. It shouldn’t even get its own navigation entry. It was like that before and thus a regression.

@MariusBluem
Copy link
Member

MariusBluem commented Apr 27, 2017

What about removing this section and adding this upload custom TLS certificate-section as an individual storage popup to the (few) use-case storages where its really needed 🤔 @icewind1991

Could this also harden Nextcloud security-wise if we restrict the certificates to the individual storages and not to the whole user? 😁 @LukasReschke

@jancborchardt
Copy link
Member Author

@icewind1991 @LukasReschke so how do we proceed here? Remove or relayout?

@MorrisJobke MorrisJobke removed this from the Nextcloud 12.0 milestone May 22, 2017
@rullzer rullzer added this to the Nextcloud 13 milestone May 23, 2017
@MorrisJobke
Copy link
Member

This one here is not useful. Please open an issue describing the actual issue.

@MorrisJobke MorrisJobke closed this Aug 9, 2017
@MorrisJobke MorrisJobke deleted the certificates-settings-hint branch August 9, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants