fix(cypress): Check for local changes before trying to apply them

[SystemKeeper]

Summary

Running a chown command inside of docker on a machine that has CONFIG_OVERLAY_FS_METACOPY disabled takes unnecessarily long. In case of cypress, we try to apply local changes and run a chown command afterwards, even when no files were actually changed/added.
This PR checks if any of the files exist, before copying them to the container and executing a chown command.

Example:

TODO

According to the comment at

server/cypress/dockerNode.ts

Lines 124 to 130 in 8359b80

	/**
	* Applying local changes to the container
	* Only triggered if we're not in CI. Otherwise the
	* continuous-integration-shallow-server image will
	* already fetch the proper branch.
	*/
	export const applyChangesToNextcloud = async function() {

This method was never intended to run on CI, but it seems to be the case since this method was introduced (#34696). It might make sense to just check for process.env.CI and never execute that method, but I am not sure if it serves a purpose for something on CI?!

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[st3iny]

Why not disable the check entirely on CI?

See also #45894

[SystemKeeper]

Why not disable the check entirely on CI?

Yea, see above:

This method was never intended to run on CI, but it seems to be the case since this method was introduced (#34696). It might make sense to just check for process.env.CI and never execute that method, but I am not sure if it serves a purpose for something on CI?!

If it doesn't serve any purpose, we should disable it completely on CI. But I think this change here might even make sense when not running on CI?

[st3iny]

I agree, let's have both PRs then.

[susnux]

This breaks local testing. You are now forced to have your nextcloud repository in '/var/www/html' because otherwise it will always skip uploading.

[SystemKeeper]

But the path was /var/www/html before that PR already or did I mis-interpreted the old code ?

[susnux]

It is uploaded to /var/www/html on the docker image, but you are checking if the local path is /var/www/html/something which is not the case (probably)

[SystemKeeper]

Sorry, I mis-interpreted the tar command... Was going to take a look at this, but seems it was already fixed in #46370 - correct?

[susnux]

Yes