Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 18, 2024

When running an upgrade we have several stages that might trigger repair steps.

The Repair class has no default migration steps and there are both a setRepair and addStep methods, however for the case when we upgrade an app we do not need to run core migrations again.

This fix will ensure that after running we always empty the list of repair steps stored in the Repair class instance.

I also checked usages and for all other places we tend to overwrite the array anyways.

Also if the app has no steps itself it would skip the core migrations still around before this change anyways.

Checklist

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@st3iny st3iny enabled auto-merge June 18, 2024 12:44
@st3iny st3iny merged commit 4e840fb into master Jun 18, 2024
@st3iny st3iny deleted the perf/upgrade-reset-steps branch June 18, 2024 13:24
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants