Skip to content

Fix for missing Rich Link Preview #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
newhinton wants to merge 3 commits into from
Closed

Fix for missing Rich Link Preview #4648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f03370
Fixed Missing og:description and og:ti
newhinton May 1, 2017
223fbaf
Fixed Missing og:description and og:image
newhinton May 1, 2017
fd4c51c
Fixed Missing og:description and og:image
newhinton May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/templates/layout.base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
<meta name="referrer" content="never">
<meta name="viewport" content="width=device-width, minimum-scale=1.0, maximum-scale=1.0">
<meta name="theme-color" content="<?php p($theme->getColorPrimary()); ?>">

<meta property="og:description" content="<?php p($theme->getTitle()); p(" - "); p($theme->getSlogan()); ?>"/>
Copy link
Member

@ChristophWurst ChristophWurst May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be escaped somehow, e.g. quotes in the title or slogan could mess up the HTML otherwise.

Copy link
Member

@LukasReschke LukasReschke May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm? p() already escapes :-)

Copy link
Member

@ChristophWurst ChristophWurst May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right… nvm

Copy link
Member

@juliusknorr juliusknorr May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/files_sharing/lib/Controller/ShareController.php is already setting opengraph headers. Those should not be doubled. 😉

Copy link
Member

@juliusknorr juliusknorr May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareController.php#L403-L409

Copy link
Member

@jancborchardt jancborchardt May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhinton can you fix this? :)

<meta property="og:image" content="<?php print_unescaped(image_path('', 'favicon-fb.png')); ?>" />

<link rel="icon" href="<?php print_unescaped(image_path('', 'favicon.ico')); /* IE11+ supports png */ ?>">
<link rel="apple-touch-icon-precomposed" href="<?php print_unescaped(image_path('', 'favicon-touch.png')); ?>">
<link rel="mask-icon" sizes="any" href="<?php print_unescaped(image_path('', 'favicon-mask.svg')); ?>" color="<?php p($theme->getColorPrimary()); ?>">
Expand Down
4 changes: 4 additions & 0 deletions core/templates/layout.guest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
<meta name="viewport" content="width=device-width, minimum-scale=1.0, maximum-scale=1.0">
<meta name="apple-itunes-app" content="app-id=<?php p($theme->getiTunesAppId()); ?>">
<meta name="theme-color" content="<?php p($theme->getColorPrimary()); ?>">

<meta property="og:description" content="<?php p($theme->getTitle()); p(" - "); p($theme->getSlogan()); ?>"/>
<meta property="og:image" content="<?php print_unescaped(image_path('', 'favicon-fb.png')); ?>" />

<link rel="icon" href="<?php print_unescaped(image_path('', 'favicon.ico')); /* IE11+ supports png */ ?>">
<link rel="apple-touch-icon-precomposed" href="<?php print_unescaped(image_path('', 'favicon-touch.png')); ?>">
<link rel="mask-icon" sizes="any" href="<?php print_unescaped(image_path('', 'favicon-mask.svg')); ?>" color="<?php p($theme->getColorPrimary()); ?>">
Expand Down
4 changes: 4 additions & 0 deletions core/templates/layout.user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
<meta name="apple-mobile-web-app-title" content="<?php p((!empty($_['application']) && $_['appid']!='files')? $_['application']:$theme->getTitle()); ?>">
<meta name="mobile-web-app-capable" content="yes">
<meta name="theme-color" content="<?php p($theme->getColorPrimary()); ?>">

<meta property="og:description" content="<?php p($theme->getTitle()); p(" - "); p($theme->getSlogan()); ?>"/>
Copy link
Member

@juliusknorr juliusknorr May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in the layout.user.php file? This file will not be crawled by any of the services since it requires login, right?

<meta property="og:image" content="<?php print_unescaped(image_path('', 'favicon-fb.png')); ?>" />

<link rel="icon" href="<?php print_unescaped(image_path($_['appid'], 'favicon.ico')); /* IE11+ supports png */ ?>">
<link rel="apple-touch-icon-precomposed" href="<?php print_unescaped(image_path($_['appid'], 'favicon-touch.png')); ?>">
<link rel="mask-icon" sizes="any" href="<?php print_unescaped(image_path($_['appid'], 'favicon-mask.svg')); ?>" color="<?php p($theme->getColorPrimary()); ?>">
Expand Down