Skip to content

Conversation

@Ornanovitch
Copy link
Contributor

Summary

Let the browser do its job regarding the appearance of the scrollbar

Sorry for the two unrelated changes, my neovim doesn't love trailing spaces 😸

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Screenshots before/after for front-end changes (idk how to screenshot with the scrollbar always visible...)
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the current scrollbar is not very accessible.
So I fully support removing the scrollbar-width, but for the scrollbar-color I think we should use theming.
The color is broken it should be var(--color-border-maxcontrast) transparent and for our high-contrast themes we should set it to auto.

But would also be fine with removing the styles for the scrollbar if designers agree with that :)

Before

Bildschirmaufnahme_20240830_031750.webm

After (this PR)

Bildschirmaufnahme_20240830_031648.webm

@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 30, 2024
@susnux susnux added this to the Nextcloud 31 milestone Aug 30, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux Good point with using color-text-maxcontrast for the scrollbar color. @Ornanovitch could you adjust that?

Otherwise it looks good. :)

@Ornanovitch
Copy link
Contributor Author

Thanks a lot for this quick review! I'm fine with the theming, I will adjust in a few hours :)

And thx for the screen-casts @susnux, I'll try to figure out how to make those easily

@Ornanovitch Ornanovitch force-pushed the ornano/scrollbar-visibility branch from 87d91c3 to 65c4394 Compare August 31, 2024 13:00
@Ornanovitch Ornanovitch requested a review from susnux August 31, 2024 13:04
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @Ornanovitch!

Btw, are you already in our Design room (link on https://nextcloud.com/design ) – I can also give you a guest account if you don't have one yet.

And are you aware of our Community Conference in Berlin? :) https://nextcloud.com/conf

@Ornanovitch
Copy link
Contributor Author

The pleasure is all mine, I'd love to work on the Nextcloud design from time to time :)

Btw, are you already in our Design room (link on https://nextcloud.com/design ) – I can also give you a guest account if you don't have one yet.

I'm not, let's go!

And are you aware of our Community Conference in Berlin? :) https://nextcloud.com/conf

I'll check this out :)

Thanks again!

Signed-off-by: protoclown <ornano@felinn.org>
Signed-off-by: protoclown <ornano@felinn.org>
Signed-off-by: protoclown <ornano@felinn.org>
Signed-off-by: protoclown <ornano@felinn.org>
@susnux susnux force-pushed the ornano/scrollbar-visibility branch from 588c4c2 to b711da7 Compare September 2, 2024 15:04
@susnux
Copy link
Contributor

susnux commented Sep 2, 2024

@Ornanovitch could you please run npm run sass locally and commit the files?

Signed-off-by: protoclown <ornano@felinn.org>
@Ornanovitch
Copy link
Contributor Author

done!

@AndyScherzinger AndyScherzinger merged commit 87f8a8c into nextcloud:master Sep 2, 2024
@welcome
Copy link

welcome bot commented Sep 2, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger
Copy link
Member

Nice work @Ornanovitch - sent you an invite to the Github organization of Nextcloud so you don't need to work via a fork for contributions. Should make life easier for you 👍

Thanks for your work on the fix 💯

@susnux
Copy link
Contributor

susnux commented Sep 2, 2024

/backport to stable30

@backportbot
Copy link

backportbot bot commented Sep 2, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47617/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick afc4940f d1f82e7f df7db817 b711da73 15e449a7

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47617/stable30

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..87f8a8c
From https://github.com/nextcloud/server

  • [deleted] (none) -> origin/7935-download-files-via-post
  • [deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
  • [deleted] (none) -> origin/add-clear-add-to-user-status-public-api
  • [deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
  • [deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
  • [deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
  • [deleted] (none) -> origin/artonge/feat/download_providers
  • [deleted] (none) -> origin/bug/files-scroll
  • [deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
  • [deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
  • [deleted] (none) -> origin/bugfix/noid/unavailable-shares
  • [deleted] (none) -> origin/cache-mimtype-mapping
  • [deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
  • [deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
  • [deleted] (none) -> origin/dependabot/npm_and_yarn/core-js-3.38.1
  • [deleted] (none) -> origin/direct-access-shared-calendar
  • [deleted] (none) -> origin/email-template-html-fragment
  • [deleted] (none) -> origin/enh/a11y-util
  • [deleted] (none) -> origin/enh/noid/iconfig
  • [deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
  • [deleted] (none) -> origin/enhancement/caldav-resources-sync-command
  • [deleted] (none) -> origin/enhancement/typed-db-entity
  • [deleted] (none) -> origin/external-list-for
  • [deleted] (none) -> origin/extract-caldav-sharing-plugin
  • [deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
  • [deleted] (none) -> origin/feat/mail-admin-vue
  • [deleted] (none) -> origin/file-cache-insertion-atomic
  • [deleted] (none) -> origin/fix/44160/ctrl-f-trigger-global-search
  • [deleted] (none) -> origin/fix/files-non-visual-loading-info
  • [deleted] (none) -> origin/fix/header-styles
  • [deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
  • [deleted] (none) -> origin/fix/user-settings-admin
  • [deleted] (none) -> origin/home-storage-lazy-datadir
  • [deleted] (none) -> origin/introduce/orm
  • [deleted] (none) -> origin/locate-key-fix
  • [deleted] (none) -> origin/mountcache-lazy-user
  • [deleted] (none) -> origin/multi-object-store
  • [deleted] (none) -> origin/remove_depreated_files
  • [deleted] (none) -> origin/setupmanager-lazy-user
  • [deleted] (none) -> origin/share-null-source
  • [deleted] (none) -> origin/storage-cache-init-in-transaction
  • [deleted] (none) -> origin/trashbin-skip-logging
  • [deleted] (none) -> origin/upload-chunk-locking
  • [deleted] (none) -> origin/use_HSTS
  • [deleted] (none) -> origin/user-files-debug-info
  • [deleted] (none) -> origin/work/sharing_trash
    error: Your local changes to the following files would be overwritten by merge:
    dist/4254-4254.js.map.license
    dist/4696-4696.js.map.license
    dist/5643-5643.js.map.license
    Please commit your changes or stash them before you merge.
    Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@Ornanovitch Ornanovitch deleted the ornano/scrollbar-visibility branch September 2, 2024 16:40
@jancborchardt
Copy link
Member

The pleasure is all mine, I'd love to work on the Nextcloud design from time to time :)

@Ornanovitch awesome, you should get an email with the details for the account. :) Added you to the "Design team" chat already.
And congrats, your contribution will be in the upcoming release in 2 weeks!

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

skjnldsv commented Feb 5, 2025

This broke the high contrast sidebar :(
#49426

auto seems to not work on webkit browsers.
auto transparent fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visibility of scroll bar in main UI

6 participants