Skip to content

ci: Don't upload output of normal psalm to GitHub Security section #48476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 3 commits into from
Oct 1, 2024
Merged

ci: Don't upload output of normal psalm to GitHub Security section #48476

kesselb merged 3 commits into from
Oct 1, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 30, 2024

Summary

  • Start tracking psalm:security baseline
  • Fail CI when it increases
  • Don't pollute GitHub security tab with normal psalm deprecations

Checklist

@nickvergessen
ci: Improve usability of running different psalm modes locally
95bafb4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Don't upload output of normal psalm to GitHub Security section
990ee44 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Add psalm baseline for security and make CI fail on change
570a9e2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Sep 30, 2024
@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Sep 30, 2024
@nickvergessen nickvergessen self-assigned this Sep 30, 2024
@kesselb kesselb merged commit f0f4a31 into master Oct 1, 2024
@kesselb kesselb deleted the ci/noid/improve-running-psalm-locally branch October 1, 2024 08:46
@kesselb kesselb mentioned this pull request Nov 26, 2024
Merged
2 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @kesselb @provokateurin