Update & Expand Meta Tags #49872

solonovamax · 2024-12-15T05:47:33Z

Summary

Improves/expands the meta tags for shared files.

Adds the following opengraph tags, depending on the file type
- images:
  - og:image:type: the mimetype of the image file (TODO: should this be added for all shared files? all files will always have an og:image tag with either the preview or the nc logo)
- audio:
  - og:audio: a direct link to the audio file
  - og:audio:type: the mimetype of the audio file
- video:
  - og:video: a direct link to the video file
  - og:video:type: the mimetype of the video file
Updates the og:type tag from object (which is not a type that exists, as far as I can tell) to website
Adds meta tags for twitter
- twitter:title: same as og:title
- twitter:description: same as og:description
- twitter:card: summary_large_image if the shared file is an image & it has a preview, otherwise summary
- twitter:image: same as og:image

Before changes

After changes

Note

I tested this on my personal self-hosted nextcloud, which is running nextcloud 29.0.10. I did this by just manually editing the apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php file.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php

solonovamax · 2024-12-15T19:30:13Z

Applied requested changes.

solonovamax · 2024-12-15T20:34:32Z

I've also added some additional changes to the opengraph meta tags. I will update the title/description in 15-20 with the additional changes.

Edit: updated

solonovamax · 2024-12-15T22:22:45Z

~~oops, accidentally left in some funny formatting. I'll fix that in a bit.~~
Edit: fixed

other than that, the other failing checks seem to be either flaky tests, broken tests, or checks which won't run on forks.

come-nc · 2024-12-16T13:26:00Z

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php

+		Util::addHeader('meta', ['property' => 'twitter:title', 'content' => $title]);
+		Util::addHeader('meta', ['property' => 'twitter:description', 'content' => $description]);
+		Util::addHeader('meta', ['property' => 'twitter:card', 'content' => $hasImagePreview ? 'summary_large_image' : 'summary']);
+		Util::addHeader('meta', ['property' => 'twitter:image', 'content' => $ogPreview]);


Why are we adding twitter specific tags? Can’t it read the standard tags?

Why are we adding twitter specific tags? Can’t it read the standard tags?

It can, however imo it doesn't look as nice. yes, technically only the twitter:card tag is needed as it will fall back to the opengraph tags, however there is no harm in including them. (& there may be some services which only support the twitter tags, or if one of the twitter tags is present, it only uses twitter tags. unsure, as I have not tested this)

solonovamax · 2024-12-28T18:57:37Z

Any updates on the review?

github-actions · 2024-12-30T02:00:07Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

sorbaugh · 2025-02-14T15:02:19Z

Re-requesting reviews..

Adds the following twitter meta tags - `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary` - `twitter:title`: same as `og:title` - `twitter:description`: same as `og:description` - `twitter:image`: same as `og:image` Fixes nextcloud#49871 Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>

…pengraph type to website - Adds the following opengraph tags - images: - `og:image:type`: the mimetype of the image file - audio: - `og:audio`: a direct link to the audio file - `og:audio:type`: the mimetype of the audio file - video: - `og:video`: a direct link to the video file - `og:video:type`: the mimetype of the video file - Changes th `og:type` meta tag from `object` (which is not valid) to `website` Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>

welcome · 2025-02-17T13:00:23Z

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

solonovamax · 2025-08-16T08:35:28Z

this was merged into 31.0.0, correct? bc on my nextcloud instance which is on version 31.0.7, I'm not seeing these changes

susnux · 2025-08-16T10:34:24Z

No its merged for Nextcloud 32 as you can see by the milestone

solonovamax · 2025-08-17T18:40:33Z

No its merged for Nextcloud 32 as you can see by the milestone

ah, it doesn't show that to me on mobile, which is probably why. I could only see where it was mentioned, and it was only mentioned in PRs for nc 31

well, hopefully nc 32 will happen sometime soon, bc it'll make sharing nc links to other social media much nicer

susnux · 2025-08-17T20:53:37Z

well, hopefully nc 32 will happen sometime soon, bc it'll make sharing nc links to other social media much nicer

Yes: 2025-09-27
See also https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule#nextcloud-32

solracsf linked an issue Dec 15, 2024 that may be closed by this pull request

Add Twitter Meta Tags #49871

Closed

This comment was marked as resolved.

Sign in to view

solracsf reviewed Dec 15, 2024

View reviewed changes

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php Outdated Show resolved Hide resolved

solracsf added this to the Nextcloud 31 milestone Dec 15, 2024

solracsf added the 3. to review Waiting for reviews label Dec 15, 2024

solracsf reviewed Dec 15, 2024

View reviewed changes

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php Show resolved Hide resolved

solonovamax force-pushed the master branch 2 times, most recently from dc9182d to 2a53ae7 Compare December 15, 2024 19:29

solonovamax force-pushed the master branch from 2a53ae7 to 8e7cdf9 Compare December 15, 2024 19:43

solracsf requested review from come-nc, skjnldsv and susnux December 15, 2024 19:47

solonovamax changed the title ~~Add Twitter Meta Tags~~ Update & Expand Meta Tags Dec 15, 2024

come-nc reviewed Dec 16, 2024

View reviewed changes

solonovamax force-pushed the master branch from 7a6611d to e1af281 Compare December 16, 2024 19:10

skjnldsv removed request for skjnldsv and susnux December 17, 2024 12:21

github-actions bot added the feedback-requested label Dec 30, 2024

blizzz mentioned this pull request Jan 8, 2025

31.0.0 beta 2 #50095

Merged

This was referenced Jan 14, 2025

31.0.0 beta 3 #50178

Merged

31.0.0 beta 4 #50216

Merged

This was referenced Jan 21, 2025

31.0.0 beta 5 #50285

Merged

31.0.0 RC1 #50329

Merged

blizzz mentioned this pull request Jan 29, 2025

31.0.0 RC2 #50538

Merged

1 task

blizzz removed this from the Nextcloud 31 milestone Jan 29, 2025

blizzz added this to the Nextcloud 32 milestone Jan 29, 2025

sorbaugh requested review from come-nc and solracsf February 14, 2025 15:01

solracsf approved these changes Feb 14, 2025

View reviewed changes

yemkareems approved these changes Feb 17, 2025

View reviewed changes

solonovamax added 2 commits February 17, 2025 12:52

susnux force-pushed the master branch from e1af281 to 9b9ea77 Compare February 17, 2025 11:52

sorbaugh merged commit 509a53c into nextcloud:master Feb 17, 2025
2 checks passed

nextcloud locked as resolved and limited conversation to collaborators Aug 17, 2025

skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025

Uh oh!

Update & Expand Meta Tags #49872

Update & Expand Meta Tags #49872

Uh oh!

Conversation

solonovamax commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Before changes

After changes

Checklist

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

solonovamax commented Dec 15, 2024

Uh oh!

solonovamax commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solonovamax commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

come-nc Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

solonovamax Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

solonovamax commented Dec 28, 2024

Uh oh!

github-actions bot commented Dec 30, 2024

Uh oh!

sorbaugh commented Feb 14, 2025

Uh oh!

Uh oh!

welcome bot commented Feb 17, 2025

Uh oh!

solonovamax commented Aug 16, 2025

Uh oh!

susnux commented Aug 16, 2025

Uh oh!

solonovamax commented Aug 17, 2025

Uh oh!

susnux commented Aug 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

solonovamax commented Dec 15, 2024 •

edited

Loading

solonovamax commented Dec 15, 2024 •

edited

Loading

solonovamax commented Dec 15, 2024 •

edited

Loading