Skip to content

fix: when already upgrading, don't instruct to run occ upgrade #49955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Feb 6, 2025
Merged

fix: when already upgrading, don't instruct to run occ upgrade #49955

artonge merged 1 commit into from
Feb 6, 2025

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Dec 21, 2024 •
edited
Loading

Summary

A usability paper cut fix.

Misleading and confusing to display this warning when the operator is, in fact, in the midst of running occ upgrade.

TODO

  • ...

Checklist

@joshtrichards joshtrichards added enhancement 3. to review Waiting for reviews feature: install and update papercut Annoying recurring UX issue with possibly simple fix. labels Dec 21, 2024
@joshtrichards joshtrichards added this to the Nextcloud 31 milestone Dec 21, 2024
@joshtrichards joshtrichards requested review from a team, Altahrim, icewind1991 and yemkareems and removed request for a team December 21, 2024 16:20
@blizzz blizzz mentioned this pull request Jan 8, 2025
Merged
This was referenced Jan 14, 2025
Merged
Merged
This was referenced Jan 21, 2025
Merged
Merged
@blizzz blizzz mentioned this pull request Jan 29, 2025
Merged
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@joshtrichards @AndyScherzinger
fix: when already upgrading, don't instruct to run occ upgrade
724811a 
Fixes #36289

Signed-off-by: Josh <josh.t.richards@gmail.com>
@artonge artonge merged commit f9c03f7 into master Feb 6, 2025
189 checks passed
@artonge artonge deleted the occ-upgrade-reminder branch February 6, 2025 15:32
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: install and update papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Remove misleading output when running occ upgrade

6 participants

@joshtrichards @susnux @artonge @blizzz @skjnldsv