-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(federatedfilesharing): get share by token fallback #49974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31ddd97 to
9664124
Compare
Member
|
/backport 895a939 to stable30 |
Member
|
/backport 895a939 to stable29 |
bc0109d to
1d4cadb
Compare
1d4cadb to
a710e0c
Compare
skjnldsv
approved these changes
Dec 27, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
a710e0c to
bc0ad5e
Compare
Member
|
Cypress runner 2 failure is unrelated, this test is flaky. I'll try to fix it on master |
yemkareems
approved these changes
Jan 2, 2025
This was referenced Jan 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #49646
Reproducing the issue
entry does not contains @.Explanations
The code check for the
FederatedShareProvider, which have its shares intooc_share.But on the receiving end, which the ocm notification gets sent, there is no shares in this table.
They're just external shares from the
oc_share_external, so we need to fetch and check them tooError
{ "reqId": "t4wJRkGxiWXx6g1uJn4Q", "level": 2, "time": "2024-12-26T12:34:55+00:00", "remoteAddr": "172.21.0.2", "user": false, "app": "cloud_federation_api", "method": "POST", "url": "/index.php/ocm/notifications", "message": "incoming request exception", "userAgent": "Nextcloud Server Crawler", "version": "31.0.0.6", "exception": { "Exception": "NCU\\Security\\Signature\\Exceptions\\IncomingRequestException", "Message": "entry does not contains @", "Code": 0, "Trace": [ { "file": "/var/www/html/apps/cloud_federation_api/lib/Controller/RequestHandlerController.php", "line": 435, "function": "getHostFromFederationId", "class": "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController", "type": "->", "args": [ "" ] }, { "file": "/var/www/html/apps/cloud_federation_api/lib/Controller/RequestHandlerController.php", "line": 423, "function": "confirmNotificationEntry", "class": "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController", "type": "->", "args": [ { "__class__": "OC\\Security\\Signature\\Model\\IncomingSignedRequest" }, "" ] }, { "file": "/var/www/html/apps/cloud_federation_api/lib/Controller/RequestHandlerController.php", "line": 254, "function": "confirmNotificationIdentity", "class": "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController", "type": "->", "args": [ { "__class__": "OC\\Security\\Signature\\Model\\IncomingSignedRequest" }, "file", { "sharedSecret": "la0KxWqDj08lrUZ", "message": "file is no longer shared with you" } ] }, { "file": "/var/www/html/lib/private/AppFramework/Http/Dispatcher.php", "line": 200, "function": "receiveNotification", "class": "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController", "type": "->", "args": [ "SHARE_UNSHARED", "file", "30", { "sharedSecret": "la0KxWqDj08lrUZ", "message": "file is no longer shared with you" } ] }, { "file": "/var/www/html/lib/private/AppFramework/Http/Dispatcher.php", "line": 114, "function": "executeController", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->", "args": [ { "__class__": "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController" }, "receiveNotification" ] }, { "file": "/var/www/html/lib/private/AppFramework/App.php", "line": 161, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->", "args": [ { "__class__": "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController" }, "receiveNotification" ] }, { "file": "/var/www/html/lib/private/Route/Router.php", "line": 306, "function": "main", "class": "OC\\AppFramework\\App", "type": "::", "args": [ "OCA\\CloudFederationAPI\\Controller\\RequestHandlerController", "receiveNotification", { "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer" }, { "_route": "cloud_federation_api.requesthandler.receivenotification" } ] }, { "file": "/var/www/html/lib/base.php", "line": 1019, "function": "match", "class": "OC\\Route\\Router", "type": "->", "args": [ "/ocm/notifications" ] }, { "file": "/var/www/html/index.php", "line": 24, "function": "handleRequest", "class": "OC", "type": "::", "args": [] } ], "File": "/var/www/html/apps/cloud_federation_api/lib/Controller/RequestHandlerController.php", "Line": 455, "message": "incoming request exception", "exception": {}, "CustomMessage": "incoming request exception" } }