fix(theming): Harden admin theming settings #50293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Merged
susnux
force-pushed
the
fix/harden-admin-settings
branch
from
2442f6b to
44b8d85
Compare
Pytal
approved these changes
Jan 21, 2025
Merged
Member
|
/backport to stable31 |
artonge
approved these changes
Jan 27, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/harden-admin-settings
branch
from
44b8d85 to
8aa3a15
Compare
This was referenced Jan 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure there is no
"within the link to prevent XSS.This is not a security issue as per our threat model as this can only be set by admin and admin can do everything.
But its hardens it (e.g. accidentally using an URL containing a double quote).
Checklist