Skip to content

Fix example theme #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jun 13, 2017
Merged

Fix example theme #5061

MorrisJobke merged 1 commit into from
Jun 13, 2017

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 23, 2017 •
edited
Loading

Otherwise the login page will not be themed. #5036

Move styles.css to server.css

Before:
2017-05-23-111809_943x456_scrot

After:
2017-05-23-111726_951x440_scrot

@juliusknorr juliusknorr mentioned this pull request May 23, 2017
Closed
@juliusknorr juliusknorr force-pushed the example-theme-guest branch from 0309c77 to 125c231 Compare May 23, 2017 10:09
@codecov
Copy link

codecov bot commented May 23, 2017 •
edited
Loading

Codecov Report

Merging #5061 into master will increase coverage by 22.85%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #5061       +/-   ##
=============================================
+ Coverage     31.29%   54.14%   +22.85%     
- Complexity    22282    22283        +1     
=============================================
  Files          1379     1379               
  Lines         84747    85337      +590     
  Branches       1322     1322               
=============================================
+ Hits          26520    46209    +19689     
+ Misses        58227    39128    -19099
Impacted Files Coverage Δ Complexity Δ
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
core/js/js.js 61.21% <0%> (-0.57%) 0% <0%> (ø)
lib/private/Files/Storage/DAV.php 64.81% <0%> (+0.21%) 161% <0%> (ø) ⬇️
lib/private/Files/Stream/Encryption.php 75.92% <0%> (+0.46%) 53% <0%> (ø) ⬇️
lib/private/Installer.php 47.14% <0%> (+0.71%) 74% <0%> (ø) ⬇️
lib/private/Setup.php 12.39% <0%> (+0.85%) 50% <0%> (ø) ⬇️
lib/public/AppFramework/Db/Mapper.php 99.12% <0%> (+0.87%) 30% <0%> (ø) ⬇️
lib/private/legacy/image.php 39.06% <0%> (+0.88%) 212% <0%> (ø) ⬇️
lib/private/Group/Group.php 87.96% <0%> (+0.92%) 52% <0%> (ø) ⬇️
lib/private/Comments/Comment.php 96.22% <0%> (+0.94%) 55% <0%> (ø) ⬇️
... and 365 more

@juliusknorr
Move styles.css to server.css
22607b5 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the example-theme-guest branch from 125c231 to 22607b5 Compare May 23, 2017 10:10
rullzer
rullzer approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@MorrisJobke MorrisJobke merged commit 262e6fc into master Jun 13, 2017
@MorrisJobke MorrisJobke deleted the example-theme-guest branch June 13, 2017 22:48
@MorrisJobke
Copy link
Member

MorrisJobke commented Jun 20, 2017

cc @karlitschek @juliushaertl For the backport

@karlitschek
Copy link
Member

karlitschek commented Jun 20, 2017

nice. please backport 👍

@juliusknorr juliusknorr mentioned this pull request Jun 20, 2017
Merged
@juliusknorr
Copy link
Member Author

juliusknorr commented Jun 20, 2017

backport at #5489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: theming regression

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr @MorrisJobke @karlitschek @rullzer