Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 3, 2025

Backport of #50260

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, nfebe and szaimen February 3, 2025 11:49
@backportbot backportbot bot added enhancement 3. to review Waiting for reviews labels Feb 3, 2025
@backportbot backportbot bot added this to the Nextcloud 30.0.6 milestone Feb 3, 2025
nfebe added 3 commits February 3, 2025 17:19
This addition enhances the testing framework for public sharing by
improving the setup and management of share contexts.

Additionally, the update optimizes share permission adjustments and
improves state management, making public share setups more efficient and maintainable.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations:

- Password and expiration date enforced
- Password enforced with a default expiration date
- Expiration date enforced with optional password
- Default password and expiration date without enforcement
- Password enforced, expiration date set but not enforced
- Both password and expiration date not enforced, but defaults set
- Password not enforced, expiration date enforced
- Password not enforced, default expiration date set
- Password and expiration date not enforced with no defaults

The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the backport/50260/stable30 branch from 51ee89e to f5f7687 Compare February 3, 2025 16:21
@nfebe
Copy link
Contributor

nfebe commented Feb 3, 2025

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe marked this pull request as ready for review February 3, 2025 16:48
@nfebe nfebe merged commit b9af883 into stable30 Feb 3, 2025
117 checks passed
@nfebe nfebe deleted the backport/50260/stable30 branch February 3, 2025 16:48
@Altahrim Altahrim mentioned this pull request Feb 5, 2025
15 tasks
@nfebe
Copy link
Contributor

nfebe commented Feb 6, 2025

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants