Skip to content

Conversation

@GitHubUser4234
Copy link
Contributor

Please refer to owncloud/core#25114 .

@MorrisJobke
Copy link
Member

Same as #519 -> closing

@GitHubUser4234
Copy link
Contributor Author

@MorrisJobke it's a related but different feature and different branch. As long as #519 stays open, this one should also.

@MorrisJobke
Copy link
Member

@MorrisJobke it's a related but different feature and different branch. As long as #519 stays open, this one should also.

It has the exact same commits, so it is exactly the same. There is not a single difference. Could you please clarify what the difference of those two PRs should be?

@MorrisJobke
Copy link
Member

There is not a single difference. Could you please clarify what the difference of those two PRs should be?

Sorry if this sounds rude, it shouldn't, but I can't spot a difference 😢

@GitHubUser4234
Copy link
Contributor Author

@MorrisJobke You are right, currently the committed source code is the same because this is a branch using the code of #519 as its base. However there are further commits outstanding that will make it different from it's base. Please see above:

GitHubUser4234 wants to merge 2 commits into nextcloud:master from GitHubUser4234:ldap_password_pr

"ldap_password_pr" is the branch name as opposed to "master" in #519

Thanks.

@MorrisJobke
Copy link
Member

However there are further commits outstanding that will make it different from it's base.

But until there is no additional commit in the PR it makes no sense to keep two identical PRs open. Feel free to open a new PR once those additional commits are available for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants