Don't show client info, when the app is disabled #5225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
blizzz
approved these changes
Jun 2, 2017
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Better be moved as personal settings page to the app in general, but … OK for now. Code looks good.
schiessle
requested changes
Jun 2, 2017
| </form> | ||
|
|
||
|
|
||
| <?php if(OC_APP::isEnabled('firstrunwizard')) {?> |
Member
There was a problem hiding this comment.
I would prefer to pass it as a template variable instead of using (legacy) functions in the template
Member
Author
There was a problem hiding this comment.
I just moved this.
This is stable12 want to keep it simple.
For 13 i will move it to the app directly
Member
Author
There was a problem hiding this comment.
Added to my todo list
schiessle
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com