[stable12] Allow to change avatar when groups are disables #5278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
jancborchardt,
juliusknorr,
nickvergessen,
rullzer and
schiessle
MorrisJobke
changed the title
nickvergessen
added
2. developing
nickvergessen
previously requested changes
Jun 7, 2017
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
See comment on master PR
* password form overlaps upload button and doesn't allow to click it * regression from #5259 Signed-off-by: Morris Jobke <hey@morrisjobke.de> make sure that we always clear all floating rules after the user settings parts Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
MorrisJobke
force-pushed
the
stable12-5277
branch
from
a0c2734 to
d866547
Compare
Codecov Report
@@ Coverage Diff @@
## stable12 #5278 +/- ##
===========================================
Coverage ? 54.18%
Complexity ? 22293
===========================================
Files ? 1380
Lines ? 85344
Branches ? 1322
===========================================
Hits ? 46247
Misses ? 39097
Partials ? 0 |
MorrisJobke
dismissed
nickvergessen’s stale review
Updated with the commit from the master PR
MorrisJobke
added
3. to review
Member
Author
|
Tested and works - commit contains mostly work of @schiessle - so here is the +1 from me |
LukasReschke
approved these changes
Jun 7, 2017
MorrisJobke
added
4. to release
Member
Author
|
CSS and HTML only -> merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
backport of #5277