Skip to content

fix: annotate possible exceptions #52800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
May 14, 2025
Merged

fix: annotate possible exceptions #52800

provokateurin merged 1 commit into from
May 14, 2025

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented May 13, 2025 •
edited
Loading

Summary

File.getContent can throw a GenericFileException since #37943.

Checklist

@kesselb
fix: annotate possible exceptions
866063c 
File.getContent can throw a GenericFileException since #37943.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb self-assigned this May 13, 2025
@kesselb kesselb added 2. developing Work in progress technical debt 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update and removed 2. developing Work in progress labels May 13, 2025
@kesselb kesselb marked this pull request as ready for review May 14, 2025 12:41
@kesselb kesselb requested a review from a team as a code owner May 14, 2025 12:41
@kesselb kesselb requested review from artonge, provokateurin and yemkareems and removed request for a team May 14, 2025 12:41
@kesselb kesselb added this to the Nextcloud 32 milestone May 14, 2025
@kesselb kesselb requested a review from come-nc May 14, 2025 12:41
@provokateurin provokateurin merged commit bfa494f into master May 14, 2025
196 checks passed
@provokateurin provokateurin deleted the debt/noid/simple-file-generic-exception branch May 14, 2025 13:25
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@provokateurin provokateurin provokateurin approved these changes

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@kesselb kesselb

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb @artonge @provokateurin @skjnldsv