show input fields if they are not empty but disable them in global scale mode #5287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @ChristophWurst and @icewind1991 to be potential reviewers. |
schiessle
requested review from
ChristophWurst,
MorrisJobke,
blizzz and
nickvergessen
nickvergessen
requested changes
Jun 7, 2017
settings/templates/personal.php
Outdated
| </h2> | ||
| <input type="tel" id="phone" name="phone" | ||
| value="<?php p($_['phone']) ?>" | ||
| <input type="tel" id="phone" name="phone" <?php if(!$_['lookupServerUploadEnabled']) p('disabled="1"'); ?> |
Member
There was a problem hiding this comment.
You mean print_unescaped, or do you want disabled="1"
Member
Author
There was a problem hiding this comment.
it works also this way... 😉 But I will fix it...
…ale mode Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
force-pushed
the
personal-page-gs-mode
branch
from
3271c3d to
f5731e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #5287 +/- ##
============================================
+ Coverage 54.16% 54.16% +<.01%
Complexity 22311 22311
============================================
Files 1380 1380
Lines 85406 85406
Branches 1321 1321
============================================
+ Hits 46257 46260 +3
+ Misses 39149 39146 -3
|
MorrisJobke
requested changes
Jun 7, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
It should not be a disabled input field, but only text. The same as it if, once you set allow_user_to_change_display_name to false in the config.php:
Member
Author
|
@MorrisJobke now they should all look the same |
…ut fields Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
force-pushed
the
personal-page-gs-mode
branch
from
0735d06 to
1ad4268
Compare
nickvergessen
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In global scale mode we don't allow to enter additional user information used for the lookup sever but we should still show the user existing data stored.
fix #5275
Steps to test:
'gs.enabled' => truein the config.php'gs.enabled' => falsein the config.php'gs.enabled' => truein the config.php