Skip to content

Better error message on invalid sharing link #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jun 13, 2017
Merged

Better error message on invalid sharing link #5367

MorrisJobke merged 1 commit into from
Jun 13, 2017

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 13, 2017

Fix #5346

@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Jun 13, 2017
LukasReschke
LukasReschke requested changes Jun 13, 2017
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing now 🙈

@nextcloud nextcloud deleted a comment from codecov bot Jun 13, 2017
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 13, 2017

👍 thanks

@nickvergessen
Fix unknown share token
0f8c1b1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov
Copy link

codecov bot commented Jun 13, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@906b240). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #5367   +/-   ##
=========================================
  Coverage          ?   31.27%           
  Complexity        ?    22311           
=========================================
  Files             ?     1381           
  Lines             ?    84861           
  Branches          ?     1325           
=========================================
  Hits              ?    26543           
  Misses            ?    58318           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
lib/private/Share20/ProviderFactory.php 0% <0%> (ø) 29 <0> (?)
lib/private/Share20/DefaultShareProvider.php 0% <0%> (ø) 114 <0> (?)

MorrisJobke
MorrisJobke approved these changes Jun 13, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish backport-request and removed 3. to review Waiting for reviews labels Jun 13, 2017
@nickvergessen nickvergessen mentioned this pull request Jun 13, 2017
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 13, 2017

Backport in #5387

@MorrisJobke MorrisJobke merged commit 101d1c0 into master Jun 13, 2017
@MorrisJobke MorrisJobke deleted the better-share-error branch June 13, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @MorrisJobke @LukasReschke