-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add white version of the calendar.svg icon #5447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There's no reason for not including it and it is needed for Deck app. Signed-off-by: Marin Treselj <marin@pixelipo.com>
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep the viewbox attribute though, so all icon resizing in the apps menu and app management works on Firefox, right? cc @MorrisJobke
|
@jancborchardt then what about core/img/places/files-dark.svg ? |
Codecov Report
@@ Coverage Diff @@
## master #5447 +/- ##
============================================
- Coverage 54.14% 54.13% -0.01%
Complexity 22329 22329
============================================
Files 1380 1380
Lines 85544 85544
Branches 1329 1329
============================================
- Hits 46314 46311 -3
- Misses 39230 39233 +3
|
Correct
Please add it there as well. We had weird rendering issues in firefox, especially if the view box is not there and the path is defined in a bigger scope, then firefox misrendered it |
Also removed some unneeded style declarations. Signed-off-by: Marin Treselj <marin@pixelipo.com>
|
Ok, now all the places icons (apart from |
|
We should also introduce a class icon-calendar like there is one for icon-calendar-dark already. |
Signed-off-by: Marin Treselj <marin@pixelipo.com>
|
Failures unrelated, merging. :) |
There's no reason for not including it and it is needed for Deck app in nextcloud/deck#189
@nextcloud/designers @juliushaertl
Signed-off-by: Marin Treselj marin@pixelipo.com