Restore "Others with access" section #54667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
szaimen
approved these changes
Aug 27, 2025
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Tested, works and LGTM. Thanks for fixing
Contributor
|
/backport to stable31 |
susnux
approved these changes
Aug 27, 2025
Contributor
|
/compile rebase |
The condition was checking shares.length to display the Others with access component, but shares is filled only on expanding that section, rendering the section never visible. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/51733/othersWithAccessMissing
branch
from
08ccf66 to
51468bc
Compare
2 tasks
Merged
Contributor
Author
|
Note for tracking purposes: The change hiding the section was introduced in #50282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition was checking shares.length to display the Others with access component, but shares is filled only on expanding that section, rendering the section never visible.
Summary
The section "Others with access" disappeared on NC 31.
A
v-ifwas added withshares.lengthto hide the section if no shares are present. However, the shares list is populated only when the component is expanded. This PR undoes the change that makes the section always invisible without a way to ever show it.Checklist