Skip to content

fix(comments): Fix missing return type on new method #54689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Aug 28, 2025
Merged

fix(comments): Fix missing return type on new method #54689

provokateurin merged 1 commit into from
Aug 28, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 28, 2025

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Aug 28, 2025
@nickvergessen nickvergessen self-assigned this Aug 28, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner August 28, 2025 06:58
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Aug 28, 2025
@nickvergessen
fix(comments): Fix missing return type on new method
102c778 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-missing-return-type branch from 6d6e5ee to 102c778 Compare August 28, 2025 06:59
@nickvergessen nickvergessen requested a review from a team as a code owner August 28, 2025 06:59
@nickvergessen nickvergessen requested review from Altahrim and removed request for a team August 28, 2025 06:59
@provokateurin provokateurin merged commit 3999dcf into master Aug 28, 2025
233 of 246 checks passed
@provokateurin provokateurin deleted the bugfix/noid/fix-missing-return-type branch August 28, 2025 09:13
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 28, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@provokateurin provokateurin provokateurin approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @AndyScherzinger @skjnldsv @CarlSchwan @provokateurin