feat(ZipFolderPlugin): always use the parent folder name as archive name #55014

susnux · 2025-09-10T13:34:59Z

Summary

for cfr#1476

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

susnux · 2025-09-10T13:35:08Z

/backport to stable32

github-actions · 2025-09-10T13:35:59Z

Possible performance regression detected

Show Output

An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/work/server/server/occ(33): require_once('...')
#9 {main}

AndyScherzinger · 2025-09-10T15:01:14Z

@susnux what happens on root level?

github-actions · 2025-09-10T15:02:35Z

Possible performance regression detected

Show Output

An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/actions-runner/_work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/actions-runner/_work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/actions-runner/_work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/actions-runner/_work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/actions-runner/_work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/actions-runner/_work/server/server/occ(33): require_once('...')
#9 {main}

AndyScherzinger · 2025-09-10T15:23:21Z

Fine by me, what do you think @jancborchardt?

github-actions · 2025-09-10T15:54:31Z

Possible performance regression detected

Show Output

An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/actions-runner/_work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/actions-runner/_work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/actions-runner/_work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/actions-runner/_work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/actions-runner/_work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/actions-runner/_work/server/server/occ(33): require_once('...')
#9 {main}

susnux · 2025-09-10T15:54:57Z

what happens on root level?

I reverted for the root and use just "download" there to prevent issues in shares where the not shared root would be used as the name.
So for root level it would stay "download.zip" (or you suggest a better name ;) )

AndyScherzinger · 2025-09-10T17:05:33Z

Sounds equally fine to me 👍

github-actions · 2025-09-10T17:28:22Z

Possible performance regression detected

Show Output

An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/actions-runner/_work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/actions-runner/_work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/actions-runner/_work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/actions-runner/_work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/actions-runner/_work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/actions-runner/_work/server/server/occ(33): require_once('...')
#9 {main}

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

github-actions · 2025-09-10T19:21:06Z

Possible performance regression detected

Show Output

An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/work/server/server/occ(33): require_once('...')
#9 {main}

backportbot · 2025-09-10T21:08:56Z

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55014/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6dede68b

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55014/stable32

Error: Failed to push branch backport/55014/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

AndyScherzinger · 2025-09-10T21:11:39Z

/backport to stable32

susnux added this to the Nextcloud 33 milestone Sep 10, 2025

susnux requested a review from a team as a code owner September 10, 2025 13:35

susnux removed the request for review from a team September 10, 2025 13:35

susnux added the enhancement label Sep 10, 2025

susnux requested review from CarlSchwan, icewind1991 and leftybournes September 10, 2025 13:35

susnux added 3. to review Waiting for reviews 🍂 2025-Autumn labels Sep 10, 2025

backportbot bot added the backport-request label Sep 10, 2025

jancborchardt approved these changes Sep 10, 2025

View reviewed changes

AndyScherzinger approved these changes Sep 10, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

susnux force-pushed the feat/always-use-parent-name branch from 18b37a7 to 00d165f Compare September 10, 2025 15:52

susnux force-pushed the feat/always-use-parent-name branch from 00d165f to e03884d Compare September 10, 2025 17:19

susnux requested a review from a team as a code owner September 10, 2025 17:19

susnux requested review from nfebe, sorbaugh and szaimen and removed request for a team September 10, 2025 17:19

feat(ZipFolderPlugin): always use the parent folder name as archive name

6dede68

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux force-pushed the feat/always-use-parent-name branch from e03884d to 6dede68 Compare September 10, 2025 19:10

susnux merged commit d1314bf into master Sep 10, 2025
213 of 219 checks passed

susnux deleted the feat/always-use-parent-name branch September 10, 2025 21:08

backportbot bot mentioned this pull request Sep 10, 2025

[stable32] feat(ZipFolderPlugin): always use the parent folder name as archive name #55020

Merged

backportbot bot removed the backport-request label Sep 10, 2025

skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025

Uh oh!

feat(ZipFolderPlugin): always use the parent folder name as archive name #55014

feat(ZipFolderPlugin): always use the parent folder name as archive name #55014

Uh oh!

Conversation

susnux commented Sep 10, 2025

Summary

Checklist

Uh oh!

susnux commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

AndyScherzinger commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

AndyScherzinger commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

susnux commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

Uh oh!

backportbot bot commented Sep 10, 2025

Uh oh!

AndyScherzinger commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

susnux commented Sep 10, 2025 •

edited

Loading