[stable32] feat: Mark OC.SystemTags as deprecated #55323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
github-actions
bot
changed the title
nickvergessen
approved these changes
Sep 26, 2025
Member
There was a problem hiding this comment.
Shouldn't this be against master then backported? Needs to be in master too in any case.
P.S. Needs docs: https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_32.html
Member
|
Never mind... I see #55320 now. |
Member
|
/compile |
joshtrichards
added
the
pending documentation
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
joshtrichards
approved these changes
Sep 26, 2025
Member
No, all old JS is to be considered used api. These functions and objects are older than the existance of our libraries and public JS definition. It's like OC_App basically. Defacto public, should be deprecated and documented properly and as long as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)