Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Oct 1, 2025

Summary

Use ESLint v9 which has much stricter rules regarding following our coding styles:
https://docs.nextcloud.com/server/latest/developer_manual/getting_started/coding_standards/javascript.html#code-style

This is a requirement for Vue 3 migration to be able to lint Vue 3 code.

Checklist

@susnux susnux force-pushed the chore/eslint-v9 branch 2 times, most recently from 199a5a6 to eb0035c Compare October 1, 2025 23:07
@susnux susnux changed the title Chore/eslint v9 chore: use ESLint v9 for linting Oct 2, 2025
@susnux susnux added 3. to review Waiting for reviews dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 2, 2025
@susnux susnux added this to the Nextcloud 33 milestone Oct 2, 2025
susnux added 2 commits October 2, 2025 10:48
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added 7 commits October 2, 2025 13:19
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
WE NEED TO EMPTY THIS!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux marked this pull request as ready for review October 2, 2025 12:02
@susnux susnux requested a review from a team as a code owner October 2, 2025 12:02
@susnux susnux requested review from ArtificialOwl, icewind1991, sorbaugh and szaimen and removed request for a team October 2, 2025 12:02
@susnux susnux merged commit 4ace101 into master Oct 2, 2025
229 of 235 checks passed
@susnux susnux deleted the chore/eslint-v9 branch October 2, 2025 12:05
@artonge
Copy link
Contributor

artonge commented Oct 2, 2025

Can we keep those?

'jsdoc/require-jsdoc': 'off',
'jsdoc/require-param-description': 'off',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants