feat(preview): On demand preview migration #55649
Open
+287
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/on-demand-preview-migration
branch
5 times, most recently
from
675b624 to
a0d81ae
Compare
CarlSchwan
force-pushed
the
carl/on-demand-preview-migration
branch
from
a0d81ae to
abc8733
Compare
CarlSchwan
requested review from
icewind1991,
nfebe,
sorbaugh and
yemkareems
and removed request for
a team
When requesting previews, which we don't find in oc_previews, search in IAppData first before creating them. Move the logic from MovepreviewJob to PreviewMigrationService and reuse that in the Preview Generator. At the same time rename MovePreviewJob to PreviewMigrationJob as it is a better name. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/on-demand-preview-migration
branch
from
66a2427 to
4d4ead5
Compare
artonge
approved these changes
Jan 12, 2026
come-nc
approved these changes
Jan 12, 2026
icewind1991
approved these changes
Jan 12, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/on-demand-preview-migration
branch
from
4d4ead5 to
7a025ff
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When requesting previews, which we don't find in oc_previews, search in IAppData first before creating them.
Move the logic from MovepreviewJob to PreviewMigrationService and reuse that in the Preview Generator.
At the same time rename MovePreviewJob to PreviewMigrationJob as it is a better name.
Checklist
3. to review, feature component)stable32)