feat: perform share mount validation on share instead of on mount #57295
+430
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
Altahrim,
CarlSchwan,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
icewind1991
force-pushed
the
share-mount-validation-on-share
branch
11 times, most recently
from
bcdfc45 to
eeffc0a
Compare
CarlSchwan
approved these changes
Dec 31, 2025
3 tasks
Member
Author
|
I forgot to handle talk/circle/etc shares... It did seem suspiciously easy compared to some earlier attempts... |
icewind1991
force-pushed
the
share-mount-validation-on-share
branch
2 times, most recently
from
c8e2abd to
9f2e4a7
Compare
3 tasks
icewind1991
force-pushed
the
share-mount-validation-on-share
branch
from
9f2e4a7 to
07b9b8e
Compare
Member
Author
|
Putting this on draft to make sure it doesn't get merged without considering the needed share provider work (can't review-block my own PR...) |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-mount-validation-on-share
branch
from
07b9b8e to
f92e93a
Compare
3 tasks
2 tasks
…e positives Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #57229
Currently the share mount is validated (check that the parent exists and the share doesn't conflict with existing files for the user) when the share is mounted. This moves the check to when the share is created or a user gains access to a share.
While this is more complex then doing it at mount time, it ensures that we only pay the cost once instead of repeatedly on mount.
The existing on-mount method is also incompatible with authoritative mount points.
Requires