Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 12, 2026

Summary

One of the last remaining jQuery UI pieces.

Checklist

@susnux susnux requested review from a team as code owners January 12, 2026 17:26
@susnux susnux added 3. to review Waiting for reviews feature: ldap ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 12, 2026
@susnux susnux requested review from Altahrim, icewind1991, nfebe, sorbaugh and szaimen and removed request for a team January 12, 2026 17:26
@susnux susnux added this to the Nextcloud 33 milestone Jan 12, 2026
@susnux susnux requested review from artonge and come-nc and removed request for sorbaugh January 12, 2026 17:26
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Were you able to test it for real? 🙈

@susnux
Copy link
Contributor Author

susnux commented Jan 12, 2026

Were you able to test it for real? 🙈

The UI yes, the backend no.
Meaning backend accepts the parameters properly so should be good (there are only 3 😅 ) but I did not test the backend itself (but also did not touch it).

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the frontend-backend connection is still good, then let's merge.
Then if @come-nc passes by with a proper backend :D

@susnux susnux force-pushed the feat/migrate-user-ldap-renew branch from 2455e99 to 5f9ad33 Compare January 12, 2026 19:45
@susnux susnux force-pushed the feat/migrate-user-ldap-renew branch from 5f9ad33 to a455019 Compare January 12, 2026 20:00
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/migrate-user-ldap-renew branch from a455019 to bad5531 Compare January 12, 2026 20:48
@susnux susnux merged commit ac3d09d into master Jan 12, 2026
211 of 217 checks passed
@susnux susnux deleted the feat/migrate-user-ldap-renew branch January 12, 2026 21:56
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: ldap ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants