fix(UserPlugin): Rewrite from scratch #57511
Open
+94
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
a team,
Altahrim,
CarlSchwan,
come-nc,
nfebe,
salmart-dev and
yemkareems
and removed request for
a team
susnux
reviewed
Jan 13, 2026
| $users[$user->getUID()] = $user; | ||
| $shareeEnumeration = $this->appConfig->getValueString('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes'; | ||
| if ($shareeEnumeration) { | ||
| $shareWithGroupOnly = $this->appConfig->getValueString('core', 'shareapi_only_share_with_group_members', 'no') === 'yes'; |
Member
Author
There was a problem hiding this comment.
Yes, but I want to backport this patch, so I think it's easier to do it separately (also because it would touch a lot of other places).
ArtificialOwl
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was extremely messy and unorganized, making it impossible to understand how it works. I rewrote it from scratch and it should be a lot easier to understand what the different options do now. I haven't adjusted the tests yet, as I first want to have some reviews to validate that the new implementation is correct (I don't trust the tests at all, they are pretty badly written). Do not read the diff, it's too big and useless.
This fixes one major flaw, as email full matches in combination with restriction to group weren't working, because the users to be searched for email fullmatches were empty due to the group restriction. This can also be seen in the TODO in the code, where the email search was implemented. This TODO still needs to be addressed, as the current email search implementation will not scale well. I will also add a test for this exact scenario.