-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files_sharing): rate limit share creation 40 times per 10 minutes #57666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Was unlimited before nextcloud#50905 setting to 20/600s which proved to be too low for some legitimate human actions, e.g. chat messages with attachments in Talk. Fix that by bumping to some arbitrary higher value, until some clearer justification for having it lower or higher is determined. Signed-off-by: biredel <67849440+biredel@users.noreply.github.com>
no goal stated; just copied from review comment Signed-off-by: biredel <67849440+biredel@users.noreply.github.com>
f4631ec to
806a28d
Compare
Share creation was unlimited before #50905 setting to 20/600s. That proved to be too low for (integration tests, and more crucially) some legitimate human actions, e.g. chat messages with attachments in Talk.
Checklist
3. to review, feature component)stable32)