Skip to content

Active share validation improvements#57760

Draft
icewind1991 wants to merge 5 commits intomasterfrom
share-update-check-single
Draft

Active share validation improvements#57760
icewind1991 wants to merge 5 commits intomasterfrom
share-update-check-single

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 23, 2026 •
edited
Loading

  • For events where we know the share, only check that share

@icewind1991 icewind1991 added this to the Nextcloud 34 milestone Jan 23, 2026
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 23, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner January 23, 2026 15:03
@icewind1991 icewind1991 requested review from Altahrim, ArtificialOwl, nfebe and salmart-dev and removed request for a team January 23, 2026 15:03
@artonge artonge mentioned this pull request Jan 23, 2026
Open
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from b1a28af to 054c5c0 Compare January 23, 2026 15:19
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026
@nickvergessen
test: Run tests from nextcloud/server#57760 "fix: only validate mount…
095ab2e 
…s for new share"

Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026
@nickvergessen
test: Run tests from nextcloud/server#57760 "fix: only validate mount…
46f7a27 
…s for new share"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 054c5c0 to 3e548a5 Compare January 23, 2026 15:32
@nickvergessen nickvergessen mentioned this pull request Jan 27, 2026
Closed
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 3e548a5 to 4851386 Compare February 5, 2026 13:48
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 5, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
4dee540 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Feb 5, 2026
Draft
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 6, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
b303266 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from 000d868 to 716d880 Compare February 9, 2026 15:48
@icewind1991 icewind1991 changed the title fix: only validate mounts for new share Active share validation improvements Feb 12, 2026
@icewind1991 icewind1991 marked this pull request as draft February 12, 2026 14:09
@icewind1991
fix: only validate mounts for new share
edbbd1e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add event for user home mount having being setup
e625400 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
chore: move share recipient validation logic to a separate class
4721ebf 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: postpone receiving share validation after processing a certain …
df25e24 
…number of users

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add test for delayed share validate
b35ead2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 716d880 to b35ead2 Compare February 16, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

2 participants

@icewind1991 @CarlSchwan